scrolly #308
Merged
scrolly #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restore on load closes #305
mbostock
reviewed
Dec 4, 2023
src/render.ts
Outdated
| @@ -138,6 +138,9 @@ function renderSidebar(title = "Home", pages: (Page | Section)[], path: string): | |||
| case "false": if (!details.classList.contains("observablehq-section-active")) details.open = false; break; | |||
| } | |||
| } | |||
| window.onbeforeunload = () => sessionStorage.setItem("observablehq-sidebar-scrolly", document.querySelector("#observablehq-sidebar").scrollTop); | |||
There was a problem hiding this comment.
We should use addEventListener here (and no window.) so that the user can use window.onbeforeunload without interfering.
There was a problem hiding this comment.
I'm not sure I get the "no window." part of your comment? Is the code below ok?
Suggested change
| window.onbeforeunload = () => sessionStorage.setItem("observablehq-sidebar-scrolly", document.querySelector("#observablehq-sidebar").scrollTop); | |
| window.addEventListener("beforeunload", () => sessionStorage.setItem("observablehq-sidebar-scrolly", document.querySelector("#observablehq-sidebar").scrollTop)); |
There was a problem hiding this comment.
Instead of window.addEventListener write addEventListener since window is already the global scope.
mbostock
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #305