Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base option #747

Merged
merged 2 commits into from
Feb 10, 2024
Merged

base option #747

merged 2 commits into from
Feb 10, 2024

Conversation

mbostock
Copy link
Member

Alternative to #194 and #746. Fixes #721. Fixes #42. Only affects build, not preview.

@mbostock mbostock requested a review from Fil February 10, 2024 19:06
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay!
we need to add it to the examples

@mbostock
Copy link
Member Author

We shouldn’t need to add it to the examples, since it’ll work for any page under /framework.

@mbostock mbostock merged commit 49a3c84 into main Feb 10, 2024
2 checks passed
@mbostock mbostock deleted the mbostock/base branch February 10, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page doesn’t render correctly on a subpath Specify a root path for serving
2 participants