fix: test name override #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/nameoverride
branch
22 times, most recently
from
1b120d3
to
fff80e2
Compare
This commit tests `NameOverride`. Typically we rely on Cloudformation to pick resource names for us. In some cases however we need stable identifiers, for example IAM role names that must be assumed from our end, or functions for which we need to create a log group upfront. In those cases, we can't necessarily rely on the stack name. Cloudformation names have a maximum length of 128 characters, which far exceeds the name limits for most resources in AWS. We need to provide an override for passing a name that abides by the limits of all the resources present in a given template. This change ended up being a bit involved because I had to change the interface of our setup module. We now create three variables on setup: - a `stack_name` which is 128 characters long - an `id` which is 64 characters long - a `short` identifier which is 32 characters long We then pass in these variables as necessary to exercise the limits of our templates.
jta
force-pushed
the
joao/nameoverride
branch
from
fff80e2
to
336ff28
Compare
yasar-observe
approved these changes
Dec 21, 2023
|
🎉 This PR is included in version 1.5.0-beta.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically we rely on Cloudformation to pick resource names for us. In
some cases however we need stable identifiers, for example IAM role
names that must be assumed from our end, or functions for which we need
to create a log group upfront.
In those cases, we can't necessarily rely on the stack name.
Cloudformation names have a maximum length of 128 characters, which far
exceeds the name limits for most resources in AWS. We need to provide an
override for passing a name that abides by the limits of all the
resources present in a given template.
This change ended up being a bit involved because I had to change the
interface of our setup module. We now create three variables on setup:
stack_namewhich is 128 characters longidwhich is 64 characters longshortidentifier which is 32 characters longWe then pass in these variables as necessary to exercise the limits of
our templates.