fix(tracing): allow setting resource attributes via URL #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/tracing-resource-attr
branch
2 times, most recently
from
3fcbc44
to
d6f1c8f
Compare
obs-gh-abhishekrao
approved these changes
May 31, 2024
All our HTTP requests are outbound to a remote set, so we should set the span kind to `client`.
jta
force-pushed
the
joao/tracing-resource-attr
branch
from
d6f1c8f
to
6f9f108
Compare
|
🎉 This PR is included in version 1.19.2-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.19.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cloudformation we do not have much configuration surface area for passing in environment variables, particular for debug-only usecases such as tracing. This commit allows passing in resource attributes through query parameters for an OTEL OTLP endpoint. Since this behavior is not per-spec, we initially limit its scope to
deployment.environment, which is useful to disambiguate between collection environments.