fix(forwarder): set content-encoding on override #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/gzip-override
branch
2 times, most recently
from
d1af7bc
to
318182c
Compare
We currently rely on the S3 object being written with the correct content-encoding. There are many cases, such as `vpcflowlogs`, where the content-type is set to `gz` and the content-encoding is left blank. This commit ensures we always set the content-encoding correctly for filenames that end in `.gz`
obs-gh-abhishekrao
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently rely on the S3 object being written with the correct content-encoding. There are many cases, such as
vpcflowlogs, where the content-type is set togzand the content-encoding is left blank.This commit ensures we always set the content-encoding correctly for filenames that end in
.gz