feat: use relative stack location #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAM will handle uploading the stacks to an S3 bucket for us, which seems more appropriate than trying to figure out how to dynamically load the appropriate application Id.
|
Interesting, this fails with a warning that the template cannot be used unless first packaged (see https://stackoverflow.com/questions/74725026/cfn-lint-error-in-nested-cloudformation-stack) |
obs-gh-colinhutchinson
approved these changes
Oct 5, 2023
obs-gh-colinhutchinson
added a commit
that referenced
this pull request
Oct 12, 2023
* feat: use relative stack location SAM will handle uploading the stacks to an S3 bucket for us, which seems more appropriate than trying to figure out how to dynamically load the appropriate application Id. * fix: ignore the W3002 lint rule * chore: ran the Makefile through a linter * feat: ability to release to multiple regions * wip * feat: setup automation for github releases * feat: empty commit to force a release * fix: fix the release logic so commits to main are pre-release * fix: run the release workflow on tags as well * feat: allow for workflow dispatch to enable proper releases * fix: try debuggin why the config option doesn't work * fix: debug if the issue is the .releaserc * fix: provide absolute path to the releaserc * fix: continue debugging * feat: needs the file extension to keep node happy * feat: empty commit to force a release * feat: empty commit to force a release * feat: terraform to setup the aws / github federation * chore: check the terraform worked * feat: connect github releases with AWS SAM releases * feat: connect github releases with AWS SAM releases * chore: revert to see if we can release now * feat: connect aws sam releases w\ github releases * feat: when releasing do a build before doing the github release in case something is broken * feat: make all SAM commands region sensitive * docs: ammend the release workflow to the README.md * chore(release): add get-caller-identity to the release workflow * fix: set the release version for prerelease and full releases * fix: releases need to include the packaged.yaml cloudformation file * chore: introduce dependabot * fix: syntax error with sending arguments to the forwarder aws sam stack (#11) * chore(deps): bump github.com/google/go-cmp from 0.5.8 to 0.6.0 (#10) * chore(deps): bump github.com/aws/aws-sdk-go-v2 from 1.21.0 to 1.21.1 (#9) * chore(deps): bump actions/setup-go from 2 to 4 (#5) * chore(deps): bump actions/checkout from 2 to 4 (#4) * chore(deps): bump github.com/aws/aws-sdk-go-v2/config (#7) * chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#6) * fix: don't run releases on dependabot commits * feat: force a release * feat: add beta/latest convenience releases * fix: stable pointer only for workflow dispatch * remove references to colin --------- Co-authored-by: João Taveira Araújo <joao@observeinc.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
obs-gh-colinhutchinson
pushed a commit
that referenced
this pull request
Oct 12, 2023
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAM will handle uploading the stacks to an S3 bucket for us, which seems more appropriate than trying to figure out how to dynamically load the appropriate application Id.