feat(collection): add subscriber stack #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still missing some tests, but this should close the loop with regards to functionality.
Previously we were treating the absence of patterns or prefixes to signify "subscribe all". Semantically this is quite confusing once you try to wire it into cloudformation, where we would like to have the presence of inputs gate the installation of our app. This commit adds the ability to support wildcard on either `logGroupNamePatterns` or `logGroupNamePrefixes`. The subscriber cloudformation template is adjusted to still subscribe all log groups on install by default.
It is convenient to create a role that has access to writing to the firehose we create within our app. We don't necessarily know what service will be assuming the role however. Gate the creation of such a role on the user providing a service.
This commit adds the subscriber stack as part of collection. By default nothing is collected. Users can provide either a list of log prefixes or patterns to collect, and can use the wildcard to collect all log groups. Note that we still won't have the full "out of the box" experience yet as far as cloudwatch logs is concerned. The subscriber is still missing the eventbridge rules which trigger subscription.
obs-gh-colinhutchinson
approved these changes
Nov 20, 2023
|
🎉 This PR is included in version 1.2.0-beta.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the subscriber stack as part of collection. By default nothing is collected. Users can provide either a list of log prefixes or patterns to collect, and can use the wildcard to collect all log groups.
Note that we still won't have the full "out of the box" experience yet as far as cloudwatch logs is concerned. The subscriber is still missing the eventbridge rules which trigger subscription.