Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidentally getting dependencies with cabal #1102

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

alexfmpe
Copy link
Contributor

This make sure all dependencies are provided by nix and cabal can't won't download any, preventing one from forgetting to re-launch the shell after adding a not-currently-available package.

For instance, when doing cabal build all inside nix-shell -A shells.ghcjs

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@ymeister
Copy link

I have concerns regarding how this will play out with haskell.nix branch which is expected to become default somewhere in the future. haskell.nix uses cabal.project and *.cabal files to get the build plan, so setting active-repositories might interfere with that (though it needs to be checked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants