Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

obs-vst: Use deleteLater on editorWidget to prevent crash #92

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

walker-WSH
Copy link
Contributor

@walker-WSH walker-WSH commented Nov 23, 2021

Description

obs-vst crashes frequently after closing editor window and deleting vst filter.

Motivation and Context

this issue may be same as #77

How Has This Been Tested?

tested with pitchproof-x64.dll, many vst plugins can be reproduced
pitchproof-x64.zip

Types of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the bug label Nov 23, 2021
@jp9000 jp9000 changed the title obs-vst: Fix crash that we should delete widget later obs-vst: Use deleteLater on editorWidget to prevent crash Nov 24, 2021
@jp9000 jp9000 merged commit 50c1999 into obsproject:master Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants