Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel benchmark: Merge Sort #334

Open
Sudha247 opened this issue Apr 12, 2022 · 5 comments
Open

Add parallel benchmark: Merge Sort #334

Sudha247 opened this issue Apr 12, 2022 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@Sudha247
Copy link
Contributor

Source: https://github.com/ckoparkar/ocaml-benchmarks/blob/master/mergesort.ml

Sandmark has a mergesort (https://github.com/ocaml-bench/sandmark/blob/main/benchmarks/multicore-numerical/mergesort_multicore.ml), would be nice to compare the two versions.

@Sudha247 Sudha247 added the help wanted Extra attention is needed label Apr 12, 2022
@ernestmusong
Copy link
Contributor

Hi @Sudha247 can I work on this?

@Sudha247
Copy link
Contributor Author

Sure, you can go ahead. Please not that the benchmarks in the repo are written for an older version of domainslib and may require updating. Don't hesitate to post here if you have any questions on errors or building the benchmark.

@ernestmusong
Copy link
Contributor

Sure, you can go ahead. Please not that the benchmarks in the repo are written for an older version of domainslib and may require updating. Don't hesitate to post here if you have any questions on errors or building the benchmark.

Thanks @Sudha247 I'm getting started

@ernestmusong
Copy link
Contributor

Hi @Sudha247 I'm stuck filtering and running parallel benchmarks. I've used these commands:-

TAG='"run_in_ci"' make run_config_filtered.json
USE_SYS_DUNE_HACK=1 RUN_CONFIG_JSON=multicore_parallel_run_config.json make ocaml-versions/5.0.0+trunk.bench

But it's not filtering them. Look at this:-
Done: 2/190 (jobs: 1)

@ernestmusong
Copy link
Contributor

Sure, you can go ahead. Please not that the benchmarks in the repo are written for an older version of domainslib and may require updating. Don't hesitate to post here if you have any questions on errors or building the benchmark.

Hi @Sudha247 some benchmarks did not run successfully. So as you mentioned the need to update, please what should be updated domainslib or the benchmarks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants