-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive instrumented pausetimes using eventring #358
Comments
My proposal for this is to move from using |
Thanks @ElectreAAS. I agree with the observersation. In fact, I added the |
I have so far modified the bash script |
I don't think |
This issue and #362 seem similar. It may be better to close one of them so that the discussion is not split between the two. |
Is there an issue for tracking the development of UI / jupyter notebook for the instrument pausetimes? FYI the latency metrics should not / need not use the instrumented runtime now. The default runtime itself produces the runtime events in the ring buffer. Olly consumes this buffer to produce latency graphs. Please ensure that the builds are not using instrumented pausetimes. |
I just created an issue for it #420
OK! |
Do you need the latency graphs to be displayed on a separate page in the Sandmark Nightly service? |
I don't mind if this is a separate page or is on the same page as the |
OCaml 5 has support for eventring: https://github.com/ocaml/ocaml/blob/trunk/otherlibs/runtime_events/runtime_events.mli, a new ring-buffer based runtime tracing capability. This replaces the earlier eventlog support. The instrumented pausetimes in Sandmark used to be built on the eventlog support. This support has to be rebuilt using eventring.
Given that eventring has a nice OCaml API, it is possible that
orun
may be modified to directly produce the tail latency distribution without having to go through the python post-processing.The text was updated successfully, but these errors were encountered: