Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: change alignment within parentheses for the janestreet profile #2202

Closed
ceastlund opened this issue Nov 3, 2022 · 1 comment

Comments

@ceastlund
Copy link

A number of expressions are aligned with an opening parenthesis rather than with the code inside the parenthesis. Examples:

let x =
  f
    (if some_condition_______________________
    then consequence________________________
    else alternative________________________)
;;
let x =
  f
    ("A string _____________________"
    ^ "Another string _____________"
    ^ "Yet another string _________")
;;

In the first case, we would prefer the then and else to be aligned with the if. In the second case, we would prefer the ^ operators to be aligned with the opening "A string.

@Julow
Copy link
Collaborator

Julow commented Nov 15, 2022

I confirm this was fixed by #2203 and #2204, the output looks like that:

let x =                                
  f
    (if some_condition_______________________
     then consequence________________________
     else alternative________________________)
;;

let x =
  f
    ("A string _____________________"
     ^ "Another string _____________"
     ^ "Yet another string _________")
;;

@Julow Julow closed this as completed Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants