Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package slack.0.1 #25430

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Package slack.0.1 #25430

merged 1 commit into from
Mar 20, 2024

Conversation

sewenthy
Copy link
Contributor

@sewenthy sewenthy commented Mar 8, 2024

slack.0.1

Slack API implementation
OCaml interface for accessing Slack APIs and receiving events.



🐫 Pull-request generated by opam-publish v2.3.0

packages/slack/slack.0.1/opam Outdated Show resolved Hide resolved
@mseri
Copy link
Member

mseri commented Mar 14, 2024

@sewenthy can you upstream the fix to the opam file?

@sewenthy
Copy link
Contributor Author

@mseri I'm not sure what was the best way to do that--I added a new commit to the main repo and then run opam publish again, hope that's ok 🙏

@mseri mseri closed this Mar 14, 2024
@mseri mseri reopened this Mar 14, 2024
@mseri
Copy link
Member

mseri commented Mar 14, 2024

In general, for such changes, you can simply update the opam file in your repository without the need to re-release. But re-releasing as you did is fine as well

@Khady
Copy link
Contributor

Khady commented Mar 18, 2024

@sewenthy the build instructions are also missing from this opam file

@sewenthy
Copy link
Contributor Author

@mseri just added to this PR and @Khady added to upstream already, thanks!

@kit-ty-kate
Copy link
Member

Side note: the error in easy-format.1.0.1 is genuine. The patch file doesn't have a correct format, and it is now failing because of the switch from GNU patch to git apply in opam master, which has a stricter patch file parser.
There are a handful of packages that fail similarly, I will open a PR to fix those packages

@mseri
Copy link
Member

mseri commented Mar 20, 2024

Thanks. I'll merge this since easy format is tracked by a separate issue

@mseri mseri merged commit fd5d2a5 into ocaml:master Mar 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants