For the internal Cygwin, use --quiet-mode noinput

ocaml · May 13, 2024 · 2068837 · 2068837
1 parent d87297f
commit 2068837
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/master_changes.md b/master_changes.md
@@ -68,6 +68,7 @@ users)
 ## External dependencies
   * Pass --symlink-type native to Cygwin setup if symlinks are available [#5830 @dra27]
   * Pass --no-version-check to Cygwin setup (suppresses a message box if setup needs updating) [#5830 @dra27]
+  * Pass --quiet-mode noinput to stop the user interrupting the setup GUI [#5830 @dra27]
 
 ## Format upgrade
   * Handle init OCaml `sys-ocaml-*` eval variables during format upgrade from 2.0 -> 2.1 -> 2.2 [#5829 @dra27]

diff --git a/src/state/opamSysInteract.ml b/src/state/opamSysInteract.ml
@@ -318,7 +318,7 @@ module Cygwin = struct
          "--no-startmenu";
          "--no-write-registry";
          "--no-version-check";
-         "--quiet-mode";
+         "--quiet-mode"; "noinput";
        ] @
          match packages with
          | [] -> []
@@ -973,7 +973,7 @@ let install_packages_commands_t ?(env=OpamVariable.Map.empty) config sys_package
        stored in `sys-pkg-manager-cmd` field *)
     [`AsUser (OpamFilename.to_string (Cygwin.cygsetup ())),
      [ "--root"; (OpamFilename.Dir.to_string (Cygwin.cygroot config));
-       "--quiet-mode";
+       "--quiet-mode"; "noinput";
        "--no-shortcuts";
        "--no-startmenu";
        "--no-desktop";