-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build directories kept again for pinned packages #4255
Comments
Since few years (pr #2593), build directories are deleted bot not for pinned packages. I guess that it is because when a package is pinned, it is generally an in development package, and it is intended to be rebuild frequently, so to save time, build directory is kept. @AltGr is there another reason? Thanks for the report! |
Thanks for the response!
|
Maybe we should have a different behaviour on version pinning vs source pinning, which are pretty different in many aspects... The change should be pretty straight-forward here: https://github.com/ocaml/opam/blob/master/src/client/opamSolution.ml#L690 Have you checked if In the case of source-pinned packages, we were expecting at some point to use the data in the left-over build dir to e.g. check the git refs w.r.t. the current source; but apparently it's not used at the moment. Note that another reason to keep the build dir could be debug options and when the build failed, so that you can troubleshoot. |
Sounds much better! :-)
It does work.
Absolutely, and there's also |
#266 came up again. I have installed packages without the
--keep-build-dir
option (or corresponding environment option), yet build folders were kept and occupied 3G. Anything that could explain it?I've learned to use
opam clean
as a workaround, but I thought I'd file this issue for future users anyway.Also, FWIW, I don't know how to reproduce it. I'll try
The text was updated successfully, but these errors were encountered: