-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using hidden-version for OCaml beta releases #4432
Comments
The current implementation of |
The implementation is therefore working correctly for |
In my opinion @AltGr Would it be possible to ?:
|
@kit-ty-kate - removing from the CUDF universe makes upgrading the explicitly installed packages tricky. For example, if you have expressly installed |
(I'm totally neutral on the subject of the name of the flag, given the myriad rubbish ones I went through before this was added!) |
One possibility. The current criteria work completely correctly for switch creation - you will only get a Before subsequent |
mh, true.
yes, that would be perfect I think! |
The downside to the approach is that you can essential "opt in" to beta releases when you create the switch, but then can't change that. |
There is a small issue with modified src/client/opamClient.ml
@@ -194,7 +194,11 @@ let compute_upgrade_t
then (n, None)
else
let atom = (n, Some (`Gt, nv.version)) in
- if OpamPackage.Set.exists (OpamFormula.check atom)
+ if OpamPackage.Set.exists
+ (fun nv ->
+ OpamFormula.check atom nv &&
+ not (OpamFile.OPAM.has_flag Pkgflag_HiddenVersion
+ (OpamSwitchState.opam t nv)))
(Lazy.force t.available_packages)
then atom
else (n, None) This solves the issue in the case of Checking the whole dependency tree would be too far-fetched, but I would be in favour of adding the |
This is a tracking issue for the current status of using the
hidden-version
flag to replace theocaml-beta
package.Using ocaml/opam-repository@e4a28e4:
will create a switch with
ocaml-base-compiler.4.11.1
installed and"ocaml"
as the switch invariant.Unclear message in
opam upgrade
opam upgrade
behaves correctly, but the message aboutocaml.4.13.0
is incorrect (ocaml.4.11.1
is installed):Unexpectedly offering alpha releases
However, both
opam upgrade ocaml
andopam upgrade ocaml-base-compiler
offer 4.12.0~alpha1, which is incorrect:The text was updated successfully, but these errors were encountered: