Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam switch list-available will not display compilers flagged with avoid-version/deprecated unless --all is given #6098

Merged
merged 4 commits into from
Aug 13, 2024
Merged

opam switch list-available will not display compilers flagged with avoid-version/deprecated unless --all is given #6098

merged 4 commits into from
Aug 13, 2024

Conversation

kit-ty-kate
Copy link
Member

Fixes #6089

@kit-ty-kate kit-ty-kate added this to the 2.3.0~alpha milestone Jul 15, 2024
@rjbou rjbou self-requested a review July 22, 2024 12:26
rjbou
rjbou requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test to show the new option?

@kit-ty-kate kit-ty-kate requested a review from rjbou July 23, 2024 16:53
@kit-ty-kate
Copy link
Member Author

Is it possible to add a test to show the new option?

done

rjbou
rjbou reviewed Jul 23, 2024
View reviewed changes
src/client/opamCommands.ml Outdated Show resolved Hide resolved
src/client/opamListCommand.mli Show resolved Hide resolved
src/client/opamCommands.ml Show resolved Hide resolved
src/client/opamCommands.ml Outdated Show resolved Hide resolved
src/client/opamCommands.ml Outdated Show resolved Hide resolved
src/client/opamCommands.ml Outdated Show resolved Hide resolved
@kit-ty-kate kit-ty-kate force-pushed the list-available-all branch 3 times, most recently from 57822fa to fba30f9 Compare August 8, 2024 13:45
@kit-ty-kate kit-ty-kate requested a review from rjbou August 8, 2024 13:46
rjbou
rjbou reviewed Aug 13, 2024
View reviewed changes
src/client/opamCommands.ml Outdated Show resolved Hide resolved
@rjbou
Copy link
Collaborator

rjbou commented Aug 13, 2024

I've updated the PR with a more complete test for witch list-available (that highlighted #6152) and squashed some commits.

@kit-ty-kate kit-ty-kate force-pushed the list-available-all branch 2 times, most recently from 3f40f9e to 016cf97 Compare August 13, 2024 12:29
@kit-ty-kate kit-ty-kate requested a review from rjbou August 13, 2024 12:29
@kit-ty-kate kit-ty-kate force-pushed the list-available-all branch 2 times, most recently from 0abdc33 to 8439b15 Compare August 13, 2024 17:22
@kit-ty-kate @rjbou
switch: 'opam switch list-available' will not display compilers flagg…
cf148b8 
…ed with 'avoid-version/deprecated' unless '--all' is given
rjbou
rjbou approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kit-ty-kate kit-ty-kate merged commit d0b0d8d into ocaml:master Aug 13, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou approved these changes

Assignees
No one assigned
Labels
AREA: UI STATE: READY TO MERGE
Projects
None yet
Milestone
2.3.0~alpha1
Development

Successfully merging this pull request may close these issues.

opam switch list-available should only display packages that aren't flagged with avoid-version/deprecated
2 participants
@kit-ty-kate @rjbou