Improve performance of opam show by 300% when the package to show is given explicitly or unique #4998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…given explicitly or unique
kit-ty-kate
force-pushed
the
fix-perf-regression-opam-show
branch
from
8f526dd
to
f64c59d
Compare
|
Some timings for
(timings taken via an archlinux docker image) |
|
Haha, nice one! I guess the costly part was the |
rjbou
pushed a commit
to rjbou/opam
that referenced
this pull request
Apr 22, 2022
…am-show Improve performance of opam show by 300% when the package to show is given explicitly or unique
rjbou
pushed a commit
to rjbou/opam
that referenced
this pull request
Apr 22, 2022
…am-show Improve performance of opam show by 300% when the package to show is given explicitly or unique
rjbou
pushed a commit
to rjbou/opam
that referenced
this pull request
Apr 27, 2022
…am-show Improve performance of opam show by 300% when the package to show is given explicitly or unique
rjbou
pushed a commit
to rjbou/opam
that referenced
this pull request
Jul 12, 2022
…am-show Improve performance of opam show by 300% when the package to show is given explicitly or unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4997 and partially #4172
Before:
After: