Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core data types: ByteArray test / interop #48

Open
dckc opened this issue May 17, 2023 · 7 comments
Open

core data types: ByteArray test / interop #48

dckc opened this issue May 17, 2023 · 7 comments

Comments

@dckc
Copy link
Collaborator

dckc commented May 17, 2023

Inclusion of the datatype seems to have consensus, but Agoric lacks support, so we can't demonstrate interop yet.

A test that all 3 of Spritely, Agoric, and capnp pass would be great.

ref @erighs #5 (comment)

I believe Agoric's current implementations are already in complete conformance with everything but the following:

  • Agoric's complete absence of ByteString support
@erights
Copy link
Collaborator

erights commented Oct 12, 2023

Above I'm quoted as saying

I believe Agoric's current implementations are already in complete conformance with everything but the following:

  • Agoric's complete absence of ByteString support

Since then, at
endojs/endo#1587
I have identified more conformance issues for Agoric. Five of these are still currently unchecked, including this absence of ByteString support.

@kriskowal
Copy link
Collaborator

Please join me in very seriously expressing a preference for one of the following in reactji.

  • byte array 🚀
  • byte vector 🎉
  • byte string 👀

@kriskowal
Copy link
Collaborator

@jar398 Let’s put a record of results on the agenda for next meeting.

@dckc
Copy link
Collaborator Author

dckc commented Jan 9, 2024

Can we please postpone choosing a name until we have a test case demonstrating interoperability?

@erights
Copy link
Collaborator

erights commented Jan 9, 2024

Can we please postpone choosing a name until we have a test case demonstrating interoperability?

Just saw this. At the OCapN meeting just now, we did go with the poll winner, "byte array". I would prefer not to revisit this, but to accept it as the winner.

How might getting to an interoperable test case affect our name choice?

@dckc
Copy link
Collaborator Author

dckc commented Jan 9, 2024

How might getting to an interoperable test case affect our name choice?

I can join you in hoping that it doesn't.

I would very much like to establish a pattern where we have a test case in place when we decide issues, though. So I suppose as long as noone aims to close this issue before we have a test, I'm content.

@kriskowal
Copy link
Collaborator

I like tests and agree we should settle many issues only after we have tested code on both the Agoric and Spritely platforms. I do not understand how it would be mechanically possible for the name of an entity in the language-agnostic model could cause a concrete test to fail. I however can see how a cross-language test might reveal that the type should not exist in the data model at all.

@erights erights changed the title core data types: ByteString test / interop core data types: ByteArray test / interop Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants