From 6beb4c3d8e7d2e8f6f191d43a18e2722658f36cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98ystein=20S=C3=B8rensen?= Date: Thu, 31 Mar 2022 21:21:37 +0200 Subject: [PATCH] valgrind ok. ready for CRAN upload --- cran-comments.md | 42 ++++++++++-------------------------------- 1 file changed, 10 insertions(+), 32 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 75b76bb3..de41827b 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,8 +1,8 @@ ## Resubmission Note -This is a resubmission which introduces new sequential Monte Carlo algorithms, describing in a new vignette. In addition, several dependencies have been removed. +This is a resubmission which fixes current issues on CRAN, related to C++ code. The main changes consist in replacing bitwise comparison operator (& and |) with && and ||. ## Test Environments -* local Windows install, R 4.1.2 +* local Windows install, R 4.1.3 * windows, win-devel. * Apple Silicon (M1) via rhub. * valgrind and GCC-UBSAN via rhub. @@ -10,39 +10,17 @@ This is a resubmission which introduces new sequential Monte Carlo algorithms, d ## R CMD CHECK results -win-devel returned the following NOTE. We have carefully checked that all these DOIs are valid, and can be reached with "curl -I -L" as described in the documentation for "CRAN URL checks". We hence believe these to be false positives.: +We got -* checking CRAN incoming feasibility ... NOTE -Maintainer: 'Oystein Sorensen ' +1 NOTE, 0 WARNINGs, 0 ERRORs. -Found the following (possibly) invalid URLs: - URL: https://doi.org/10.1214/15-aos1389 - From: man/BayesMallows.Rd - man/asymptotic_partition_function.Rd - man/estimate_partition_function.Rd - Status: 500 - Message: Internal Server Error - URL: https://doi.org/10.1214/18-aoas1203 - From: man/BayesMallows.Rd - man/compute_mallows.Rd - man/generate_constraints.Rd - Status: 500 - Message: Internal Server Error +The note was, slightly dependent on platform -Found the following (possibly) invalid DOIs: - DOI: 10.1214/15-AOS1389 - From: DESCRIPTION - Status: Internal Server Error - Message: 500 - DOI: 10.1214/18-AOAS1203 - From: DESCRIPTION - Status: Internal Server Error - Message: 500 - - -The other platforms returned: - -0 NOTE, 0 WARNINGs, 0 ERRORs. +* checking installed package size ... NOTE + installed size is 23.3Mb + sub-directories of 1Mb or more: + doc 1.7Mb + libs 20.8Mb ## Downstream Dependencies The package has one downstream dependency, the package PlackettLuce. This package is not affected by this change, as it does not use any of its functions.