-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong normalization in rho plotting? #342
Comments
It would be useful to get a reproducible example for the case of multiple clusters. I've probably misunderstood, but at least in the 2 examples in the Lorenzo, can you confirm you're running the latest build (currently, 1.4.0.9002) of the package? |
Thanks for the clarification! This goes over my head, so I'll leave it to @osorensen to analyse the case. :) |
Thanks @lorenzo-zuccato and @wleoncio. I'll take a look. |
Issue fixed now. Thanks for reporting @lorenzo-zuccato. It actually turned out the ggplot2 could do much of the data processing job, so was able to remove a couple of codelines at the same time. Note that the plot design is different now, since I'm using library(BayesMallows)
set.seed(1234)
bm <- compute_mallows(potato_visual, n_clusters = 3, nmc = 1000)
bm$burnin <- 500
plot(bm, parameter = "rho", item = 1) Created on 2023-11-23 with reprex v2.0.2 |
Closed by #343 |
Hi,
I wanted to ask clarifications about the rho plotting from the function plot.BayesMallows. I was perplexed about the normalization in line 69 of the file plot.BayesMallows.R. In case of multiple clusters I think the results does not sum to 1 for every cluster. I would use something like
instead of
Hope that this makes sense :)
The text was updated successfully, but these errors were encountered: