Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all print statements #38

Closed
wleoncio opened this issue Mar 11, 2024 · 1 comment · Fixed by #49
Closed

Review all print statements #38

wleoncio opened this issue Mar 11, 2024 · 1 comment · Fixed by #49
Labels
bug Something isn't working

Comments

@wleoncio
Copy link
Member

Just a reminder before we send the package to CRAN: it's not advisable that package functions print things that the user cannot suppress somehow. All print statements should be either:

  1. Converted to message(), warning() or error() depending on the case;
  2. Converted to cat() or sprintf() and conditioned tomy_print or other verbose-like argument for cleaner printing of intermediate results

This is something CRAN reviewers invariably ask us to change, so we would save at least one review round (not to mention improve user experience) by fixing it beforehand.

@Theo-qua
Copy link
Collaborator

Okay, could we convert print for fold to a message because I will like that to be printed.

@wleoncio wleoncio added the bug Something isn't working label Jun 26, 2024
@wleoncio wleoncio linked a pull request Jul 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants