This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
fix: add rootDir from tsconfig for plugins that use it #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdx
suggested changes
Jun 18, 2018
src/ts_node.ts
Outdated
| const rootDir = (rootDirs || [])[0] | ||
| if (!rootDir || !outDir) return orig | ||
| const {rootDir, rootDirs, outDir} = tsconfig.compilerOptions | ||
| const rootDirPath = (rootDirs || (rootDir && [rootDir]) || [])[0] |
There was a problem hiding this comment.
could we instead make this const rootDirPath = rootDir || (rootDirs || [])[0]? I think rootDir should be the default if it is defined. We could improve this with _.castArray(), but we can't use lodash here unfortunately.
There was a problem hiding this comment.
Ohh yeah, that is a lot better. Let me update.
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 62.47% 62.47%
=======================================
Files 7 7
Lines 421 421
Branches 115 115
=======================================
Hits 263 263
Misses 113 113
Partials 45 45
Continue to review full report at Codecov.
|
jdx
approved these changes
Jun 18, 2018
jdx
pushed a commit
that referenced
this pull request
Jun 18, 2018
<a name="1.6.32"></a> ## [1.6.32](v1.6.31...v1.6.32) (2018-06-18) ### Bug Fixes * add rootDir from tsconfig for plugins that use it ([#39](#39)) ([a6078d1](a6078d1))
|
🎉 This PR is included in version 1.6.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.