Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable themes #852

Merged
merged 52 commits into from
Nov 9, 2023
Merged

Enable themes #852

merged 52 commits into from
Nov 9, 2023

Commits on Nov 7, 2023

  1. feat: create type for storing theme colors

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b4a49a7 View commit details
    Browse the repository at this point in the history

  2. feat: include color and @types/color, and simiplify theme schema

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    095c6a7 View commit details
    Browse the repository at this point in the history

  3. feat: set theme's default colors to white

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ad5f324 View commit details
    Browse the repository at this point in the history

  4. feat: set FORCE_COLOR to 0||3 to follow the NO_COLOR manifest

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    26a418a View commit details
    Browse the repository at this point in the history

  5. feat: create DEFAULT_THEME to store default colors

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    4c587b9 View commit details
    Browse the repository at this point in the history

  6. revert: remove NO_COLOR manifest

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f7c5912 View commit details
    Browse the repository at this point in the history

  7. feat: add new theme variables to style $, flag, and flag options

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8dbaebd View commit details
    Browse the repository at this point in the history

  8. feat: add color to section headers

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    cbdf4ca View commit details
    Browse the repository at this point in the history

  9. feat: configure default colors

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    0e823f2 View commit details
    Browse the repository at this point in the history

  10. feat: add colors for bin, command summary and version

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    0f91695 View commit details
    Browse the repository at this point in the history

  11. feat: topics, commands, bin, version, sections, dollar sign are color… 

    …ized
    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    94ea7af View commit details
    Browse the repository at this point in the history

  12. feat: configure default colors

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    3208ea3 View commit details
    Browse the repository at this point in the history

  13. feat: add feature flag to enabled/disable theme

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    20a150c View commit details
    Browse the repository at this point in the history

  14. feat: add colorize function to simplify the way colors are added to s… 

    …trings
    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    07d7501 View commit details
    Browse the repository at this point in the history

  15. feat: change all chalk.hex calls to colorize

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    1e91233 View commit details
    Browse the repository at this point in the history

  16. feat: configure OCLIF_ENABLE_THEME to have precence over PJSON prop

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    27987e4 View commit details
    Browse the repository at this point in the history

  17. feat: all theme colors are optional

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    180b179 View commit details
    Browse the repository at this point in the history

  18. fix: error TS2322: Type 'string' is not assignable to type 'boolean'

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8d561f7 View commit details
    Browse the repository at this point in the history

  19. fix: error TS2345: arg of type 'Color<ColorParam>|undefined' not assi… 

    …gnable to 'Color<ColorParam>'
    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    22d3e6d View commit details
    Browse the repository at this point in the history

  20. fix: runtime error TypeError: color.hex is not a function

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    39bf5b2 View commit details
    Browse the repository at this point in the history

  21. fix: this.pjson.oclif.enableTheme was not being evaluated when OCLIF_… 

    …ENABLE_THEME was unset
    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    7be8136 View commit details
    Browse the repository at this point in the history

  22. chore(deps): update yarn.lock

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    653c1c2 View commit details
    Browse the repository at this point in the history

  23. refactor: simplified code removing OCLIF_ENABLE_THEME constant

    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    6673ec5 View commit details
    Browse the repository at this point in the history

  24. fix: command summary was not changing its color when running the root… 

    … command
    @AllanOricil
    AllanOricil committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    80421ee View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. feat: theme is now read from ~/config/<CLI>/theme.json if one exists

    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    fd3d17e View commit details
    Browse the repository at this point in the history

  2. fix: add colors to other ARGUMENTS, EXAMPLES, DESCRIPTION, FLAGS DESC… 

    …RIPTIONS sections
    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f6c7744 View commit details
    Browse the repository at this point in the history

  3. feat: add color token for aliases

    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    7a35ca7 View commit details
    Browse the repository at this point in the history

  4. fix(test): change template strings to avoid expected results printing… 

    … bin twice
    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    92ff5ff View commit details
    Browse the repository at this point in the history

  5. fix(test): add a missing parenthesis back so that all options are wra… 

    …ped by ()
    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    7691535 View commit details
    Browse the repository at this point in the history

  6. fix(test): remove single quotes wraping default flag values

    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c252a13 View commit details
    Browse the repository at this point in the history

  7. feat: add test:debug script to ease debuging

    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9f8591b View commit details
    Browse the repository at this point in the history

  8. refactor: add a constant with all possible THEME_KEYS

    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    02fc7aa View commit details
    Browse the repository at this point in the history

  9. test: add tests to prove parsing untyped json object with color strin… 

    …gs work
    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    6b36522 View commit details
    Browse the repository at this point in the history

  10. chore(package): add new scripts to ease development while writing tests

    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    66c7cde View commit details
    Browse the repository at this point in the history

  11. revert: remove theme from PJSON because a theme will be loaded from c… 

    …onfig_dir/<CLI>/theme.json
    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    1a6b462 View commit details
    Browse the repository at this point in the history

  12. feat: add scopedEnvVarBoolean because scopedEnvVarTrue does not consi… 

    …der unset env vars
    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    7124de1 View commit details
    Browse the repository at this point in the history

  13. feat(test): add tests to prove the behavior that enables theme

    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    dce013d View commit details
    Browse the repository at this point in the history

  14. refactor: replace all scopedEnvVarTrue by scopedEnvVarBoolean, which … 

    …considers unset env variables
    @AllanOricil
    AllanOricil committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    2834517 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. test: add tests to prove the enableTheme behavior

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    c8d671d View commit details
    Browse the repository at this point in the history

  2. refactor: simplify parseTheme method

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    24ca8f5 View commit details
    Browse the repository at this point in the history

  3. chore(package): remove localhost:4873 from lock file

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    84db405 View commit details
    Browse the repository at this point in the history

  4. revert: rever scopedEnvVarBoolean back to scopedEnvVarTrue

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4927e47 View commit details
    Browse the repository at this point in the history

  5. test: add tests to prove when this.theme is set

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    c7488bb View commit details
    Browse the repository at this point in the history

  6. feat: ensure colorize returns string only

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    37588ce View commit details
    Browse the repository at this point in the history

  7. test: add tests to prove colorize works as expected

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    714d989 View commit details
    Browse the repository at this point in the history

  8. revert: rollback scopedEnvVarTrue as it was before

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    fa1f414 View commit details
    Browse the repository at this point in the history

  9. refactor: move parseTheme to src/util/util.js

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    2c9da22 View commit details
    Browse the repository at this point in the history

  10. refactor: make Theme type dinamically based on the values of THEME_KE… 

    …YS at runtime
    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    49a1446 View commit details
    Browse the repository at this point in the history

  11. fix: err TS1259: Module /@types/color/index can only be default-impor… 

    …ted using 'esModuleInterop'
    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    bc369b3 View commit details
    Browse the repository at this point in the history

  12. revert: remove enableTheme from pjson because we don't want to cli de… 

    …vs to force users to use theme
    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f9dbcbb View commit details
    Browse the repository at this point in the history

  13. revert: remove undefined as a return type for scopedEnvVarTrue

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    caaa353 View commit details
    Browse the repository at this point in the history

  14. refactor: remove config.enableTheme

    @AllanOricil
    AllanOricil committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    00a6ccd View commit details
    Browse the repository at this point in the history