Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clarifications to the behaviour of plugin:install and plugin:link #45

Merged
merged 1 commit into from
May 24, 2018
Merged

Added clarifications to the behaviour of plugin:install and plugin:link #45

merged 1 commit into from
May 24, 2018

Conversation

shazron
Copy link
Contributor

@shazron shazron commented May 24, 2018

See discussion in #43

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @shazron to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #45 into master will decrease coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   61.84%   61.33%   -0.51%     
==========================================
  Files           9        9              
  Lines         304      269      -35     
  Branches       45       39       -6     
==========================================
- Hits          188      165      -23     
+ Misses         86       77       -9     
+ Partials       30       27       -3
Impacted Files Coverage Δ
src/yarn.ts 66.66% <0%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268fb5b...894681f. Read the comment docs.

@shazron
Copy link
Contributor Author

shazron commented May 24, 2018

Not sure why codecov/project percentage decreased, I didn't change any code, just added docs...

@jdx jdx merged commit 761f251 into oclif:master May 24, 2018
@oclif-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shazron
Copy link
Contributor Author

shazron commented Jun 5, 2018

@jdxcode Looks like my changes were clobbered by the doc generation thingy. How can I make it persistent?

@jdx
Copy link
Contributor

jdx commented Jun 11, 2018

sorry about that, I should've noticed that would happen. If you add it to the description of the command it will continue to be displayed

jdx pushed a commit that referenced this pull request Jun 12, 2018
oclif-bot added a commit that referenced this pull request Jun 12, 2018
<a name="1.5.2"></a>
## [1.5.2](v1.5.1...v1.5.2) (2018-06-12)

### Bug Fixes

* Added clarifications to the behaviour of plugin:install and plugin:link ([#47](#47)) ([dc2cedf](dc2cedf)), closes [#45](#45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants