Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove TS compile step for linked plugins #569

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

cristiand391
Copy link
Member

@cristiand391 cristiand391 commented Mar 15, 2023

Reverts #517

oclif/core now uses ts-node to compile linked TS plugins at runtime so this compile step in plugins link is no longer needed.
oclif/core#650
@W-12702335@

@mshanemc
Copy link
Member

QA notes:

[in plugin/plugins] sfdx plugins:link .

I put a console.log statement in the local copy of plugins:link to make sure it hit that version.

then I deleted the /lib folder from plugin org and ran

[in plugin-org] sfdx plugins:link .

Screenshot 2023-03-15 at 8 16 14 AM

@mshanemc
Copy link
Member

disregard previous QA notes. Tested with the current CLI rc, which has the newer oclif/core, and this works fine.

@mshanemc mshanemc merged commit 0d72c61 into main Mar 16, 2023
@mshanemc mshanemc deleted the cd/remove-ts-compile-on-link branch March 16, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants