Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refresh user plugins after any install #657

Merged
merged 6 commits into from
Sep 11, 2023

Conversation

mdonnalley
Copy link
Contributor

  • Run refresh for all user plugins after every plugin install
  • Keep JIT plugins on user-installed version but only if it's greater than the version specified by the root plugin.

@W-14071765@

@iowillhoit
Copy link
Contributor

QA NOTES

  • 🟢 JIT Plugins install as expected
  • 🔴 Updating a plugin from a pre-oclif-lock version does not install locked deps
    • Modified the sf package.json to include @salesforce/plugin-custom-metadata@2.1.4
    • Ran a cmdt command to JIT install it
    • Confirmed it was 2.1.4
    • Modified the sf package.json to include @salesforce/plugin-custom-metadata@2.2.0
    • Ran sf plugins update
    • Confirmed it was 2.2.0
    • Locked deps were not installed
  • 🔴 Installing a second pluging (JIT) wipes locked deps in first
    • Have @salesforce/plugin-custom-metadata installed
    • Run sf community list template to install @salesforce/plugin-community
    • Look at deps ls -lah $HOME/.local/share/sf/node_modules/@salesforce/plugin-custom-metadata/node_modules
  • 🔴 Running sf plugins update wipes locked deps for all jit plugins

@iowillhoit
Copy link
Contributor

QA UPDATE

  • 🟢 Installing a second JIT plugin honors locks deps
  • 🟢 Running sf plugins update does not wipe locked deps
  • 🟢 Updating from a pre-oclif-lock version installs locked deps (2.1.4 to 2.2.0)
  • 🟢 Updating from an oclif-lock to another oclif-lock version installs locked deps (2.2.0 to 2.2.1)
  • 🟢 Plugin does not "rollback" after sf plugins update when you've manually installed a newer version
    • Ran sf plugins install @salesforce/plugin-custom-metadata@2.2.1
    • The jitPlugins config has 2.2.0
    • Ran sf plugins update
    • Confirmed 2.2.1 was still installed
  • 🟢 Plugins will get updated to newer versions if jitPlugins config updates
  • 🟢 Manually installed jit plugins "roll forward" if jitPlugins config updates
    • Ran sf plugins install @salesforce/plugin-custom-metadata@2.2.0
    • The jitPlugins config has 2.2.1
    • Ran sf plugins update
    • Confirmed 2.2.1 was still installed
  • 🟢 Installing a non-oclif-locked plugin works and does not affect other plugins locked deps
  • 🟢 Installing a core plugin works and does not affect other plugins locked deps

@mdonnalley mdonnalley merged commit 85c6b5c into main Sep 11, 2023
8 checks passed
@mdonnalley mdonnalley deleted the mdonnalley/refresh-all-plugins branch September 11, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants