Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git+ssh and .git urls #82

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

wyattjoh
Copy link
Contributor

@wyattjoh wyattjoh commented Sep 25, 2019

We store private repositories in git, and require support for installing plugins via that route. This adds support for those url's.

This is an enhancement on top of #74.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @wyattjoh to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #82   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           5       5           
  Lines          97      97           
  Branches       18      18           
======================================
  Misses         97      97           
Impacted Files Coverage Δ
src/commands/plugins/install.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23fc15f...265f4af. Read the comment docs.

@qci-vanstone
Copy link

qci-vanstone commented Feb 4, 2020

@wyattjoh Does this just need a unit test to pass? Could also make use of this support for some private repo hosted plugins.

@RasPhilCo
Copy link
Contributor

RasPhilCo commented Jun 17, 2020

@wyattjoh can you rebase this off master and also run the linter?

@wyattjoh
Copy link
Contributor Author

Done @RasPhilCo!

@RasPhilCo RasPhilCo merged commit f0f3185 into oclif:master Jul 2, 2020
oclif-bot added a commit that referenced this pull request Jul 2, 2020
# [1.9.0](v1.8.3...v1.9.0) (2020-07-02)

### Features

* support more git/ssh url's ([#82](#82)) ([f0f3185](f0f3185))
@oclif-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants