You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
staticdescription=`Uses bundled npm executable to install plugins into <%= config.dataDir %>
This results in the (usually) incorrect path in the generated README.md file as the users path is different from the path in CI, is different than the path on macOS, etc.
This also causes our precommit checks to fail since the README.md file is updated with the local path, which won't match what was checked in, as the path contains the username of the last committer.
Ideally, this would be removed from the description, or excepted from the README generation, so that different systems don't result in changesets when the README.md is generated.
To Reproduce
Steps to reproduce the behavior:
Generate readme on a linux system
Generate readme on a macos system
Compare the readmes, the diff will look like this:
- Uses bundled npm executable to install plugins into /home/zmully/.local/share/px
+ Uses bundled npm executable to install plugins into /Users/zmully/.local/share/px
Expected behavior
README generation should not be system dependent.
The text was updated successfully, but these errors were encountered:
Describe the bug
The description for the
install
command uses the path variableconfig.dataDir
which is system dependent:plugin-plugins/src/commands/plugins/install.ts
Line 16 in 66d04c4
This results in the (usually) incorrect path in the generated README.md file as the users path is different from the path in CI, is different than the path on macOS, etc.
This also causes our precommit checks to fail since the README.md file is updated with the local path, which won't match what was checked in, as the path contains the username of the last committer.
Ideally, this would be removed from the description, or excepted from the README generation, so that different systems don't result in changesets when the README.md is generated.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
README generation should not be system dependent.
The text was updated successfully, but these errors were encountered: