feat: only return false on 404 in hasNpmPackage #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @CGA1123 to sign the Salesforce.com Contributor License Agreement. |
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 5 5
Lines 93 93
Branches 17 17
======================================
Misses 93 93 Continue to review full report at Codecov.
|
|
Interestingly - say you wanted to install Can you fix the merge conflict and I can merge this? |
RasPhilCo
changed the title
Currently, if the registry returns anything that is not a 200 status code this function returns `false`. In the case where we are trying to check whether the package associated to a friendly name and the registry returns for example a 503 this will result in fetching and installing the wrong package. i.e. Doing `heroku plugins:install api` - Attempt to see if [`@heroku-cli/plugin-api`](https://www.npmjs.com/package/@heroku-cli/plugin-api) exists - NPM returns 503 - Install [`api`](https://www.npmjs.com/package/api)!! In this case this is fairly harmless as that particularly library doesn't do much, however, it is annoying and could be used maliciously!
|
@RasPhilCo Done ✅ |
|
Thanks @RasPhilCo 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the registry returns anything that is not a 200 status
code this function returns
false. In the case where we are trying tocheck whether the package associated with a friendly name and the registry
returns a 503 this will result in fetching and installing
the wrong package.
i.e. Doing
heroku plugins:install api@heroku-cli/plugin-apiexistsapi!!In this case, this is fairly harmless as that particularly library
doesn't do much. However, it could be used maliciously!
I think it may be better to re-raise the initial error in this scenario if we
can't be sure that the package does not exist.