Lazy loading with reconfig: true edge cases

[charandas]

I have had fair success using ocLazyLoad with ui-router-extras futureStates to lazy load requirejs-bases angular modules that define ui-router states. Huh! that line included some 4 packages.

I have had to use the reconfig: true so far. Now, I am trying to create a demo app and for some reason, I can never get the config block of the second lazy loaded module to run.

Run with the example and the first lazy loaded module (choose apple, or orange) works.
Example
Source code
ocLazyLoad code

Breakpointing in js/states/apple.js and js/states/orange.js, you will find that whichever one is clicked first gets its config block run properly, while the second lazy loaded module would not.

Any further insights as to what might be happening?

[ocombe]

Thanks for the very detailed issue, I will look into it but not until next week. In the mean time, could you try the code from this PR: #44 which you should be able to find here: https://github.com/BenBlazely/ocLazyLoad/blob/master/src/ocLazyLoad.js ?
I have to find the time to test it before I accept the PR (next week...) but maybe it will solve your problem too ? (not sure if it's related)

[charandas]

@ocombe thanks for the suggestion. This particular PR doesn't fix my issue. Would look forward to your feedback next week. Until then, take it easy.

[chrisknu]

Chiming in here, as I'm running into the same issue. It appears to be the case that if reconfig is called at any point in an element passed into invokeQueue (prior to the resolution of all promises), the loop at 664 dies. Need to read over the rest of the source for a clearer picture, but if anything, I hope this helps

[charandas]

@ocombe any more progress on this. This is non-critical for me, as it was just about writing a blog post on combining the power of ocLazyLoad with ui-router-extras. But nevertheless, a closure would be nice :)

Interestingly, I haven't yet run into this in production - if that happens, I would have to resort to eager loading.

[ocombe]

I started working on this yes, should know more tomorow (I spent most of the day catching up on emails & news)

[ocombe]

Ok it's fixed ! There was a case where reconfig would not work as expected :)
Can I use your github repo as a new example ? It's a nice complex example yet simple to understand

[charandas]

Terrific! 👍 it worked. Thanks.