Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeType + Shadows = StyleUpdateTexture bug #4255

Closed
N1ceL opened this issue Jun 22, 2021 · 2 comments
Closed

FreeType + Shadows = StyleUpdateTexture bug #4255

N1ceL opened this issue Jun 22, 2021 · 2 comments
Labels

Comments

@N1ceL
Copy link

N1ceL commented Jun 22, 2021

Version/Branch of Dear ImGui:

Version: ImGui with shadows v1.84 WIP
Branch: shadows

Back-end/Renderer/Compiler/OS

Back-ends: win32_directx10
Compiler: MSVC 19.29 x32
Operating System: Windows 10

My Issue/Question:
With FreeType when I changing in shadows settings "Corner size" or something else it just breaks fonts, shadow textures, but not rebuilds it
image

@ocornut
Copy link
Owner

ocornut commented Jun 23, 2021

OK I understand what's happening. The reloading feature (added by the 2 "experimental" commits in that branch) weren't meant to be pushed. The texture reload experiment of those 2 commits will be superseded by #3761. Once we have #3761 shadows will be able to use it.

I have force-pushed to features/shadows without those two commits (and therefore without those 4 options).

The two "extra" commits with the old texture reload experiments are
f7a2b4f
7794771

If you want to use shadows I suggest you use them without this.
I pushed shadows for visibility but it has been not as useful as expected in many situations (docking + usage of viewports), I am wondering how you are taking advantage of it? Do you have any screenshots to share?

For now I'm closing this as I've removed the 2 "faulty" commits so it shouldn't happen anymore.

@ocornut ocornut closed this as completed Jun 23, 2021
@N1ceL
Copy link
Author

N1ceL commented Jun 24, 2021

Shadow reloading not really needed, better to build it once and using texture alpha as shadows size I think. I just tested the shadows in the demo, imgui looks very nice and simple. After creating a simple font system for reloading/loading fonts with freetype for tests I found this bug in demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants