Update to use jsoo_runtime #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Nov 2, 2022
CHANGES: * Use jsoo_runtime instead of linkops(javascript) in META files (ocsigen/js_of_ocaml-ocamlbuild#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the plugin to no longer rely on the legacy
linkopts(javascript)in META files by default.Instead, we use the
jsoo_runtimevariable, similar to what's done in dune.The direct consequence is that js_of_ocaml not longer needs to be compiled with findlib support.