Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lwt 5.0.0 breaking changes notice #584

Closed
aantron opened this issue Apr 25, 2018 · 2 comments
Closed

Lwt 5.0.0 breaking changes notice #584

aantron opened this issue Apr 25, 2018 · 2 comments
Labels
Milestone

Comments

@aantron
Copy link
Collaborator

aantron commented Apr 25, 2018

Lwt 5.0.0 will be released in November 2019 or later, with some minor breaking changes. All breaking changes are announced at least three months ahead of time by Lwt, and this issue includes details on the ones scheduled for 5.0.0.



Lwt.pick will raise Invalid_argument on the empty list, instead of returning a forever-pending promise. This also applies to Lwt.choose, Lwt.npick, Lwt.nchoose, and Lwt.nchoose_split (#562).

We found only one usage in opam that could be affected by this, in package eliom. This is fixed by checking for the empty list before calling Lwt.pick, or otherwise reasoning that the argument cannot be the empty list.

cc @vasilisp @vouillon



[%lwt ...] will no longer be translated to Lwt.catch by the PPX (#527). The replacement is to use Lwt.catch directly, or try%lwt.

[%lwt ...] is found in opam packages sqlexpr and eliom.

cc @vasilisp @vouillon @mfp



The -no-debug option will be removed from the PPX (#528). It has no users in opam.


Support for Lwt_log will be removed from the PPX (#520). It has no users in opam.

@aantron
Copy link
Collaborator Author

aantron commented Aug 21, 2019

Additional breaking changes were announced by Lwt 4.3.0:

@aantron
Copy link
Collaborator Author

aantron commented Dec 20, 2019

Lwt 5.0.0 is now installable from opam!

@aantron aantron closed this as completed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant