Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writev needed on Windows for Httpaf #745

Closed
ulrikstrid opened this issue Nov 15, 2019 · 1 comment · Fixed by #753
Closed

writev needed on Windows for Httpaf #745

ulrikstrid opened this issue Nov 15, 2019 · 1 comment · Fixed by #753
Milestone
4.5.0

Comments

@ulrikstrid
Copy link
Contributor

I'm trying to get Httpaf working on Windows and I now have it compiling but it fails at runtime with Fatal error: exception Lwt_sys.Not_available("unix_writev").

In the docs it's stated that it probably could be implemented

Not implemented on Windows. It should be possible to implement, upon request, for Windows sockets only.

What needs to happen to make this happen?
This was referenced Nov 15, 2019
Merged
Closed
@aantron
Copy link
Collaborator

aantron commented Nov 16, 2019

The easiest thing to do at first is to forward to regular write on Windows, and write only the first buffer. This is what Httpaf used to do on Unix as well, when using Lwt, before Unix writev was added.

@aantron aantron added this to the 4.5.0 milestone Nov 16, 2019
@lessp lessp mentioned this issue Nov 23, 2019
Closed
@aantron aantron mentioned this issue Dec 14, 2019
Merged
@aantron aantron mentioned this issue Dec 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

Initial implementation of readv, writev on Windows ocsigen/lwt
2 participants
@ulrikstrid @aantron