Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: codespaces permission, dependabot_secrets permission, contents:read permission now includes GET /repos/{owner}/{repo}/codeowners/errors",contents:write permission now includes POST /repos/{owner}/{repo}/comments/{comment_id}/reactions and POST /repos/{owner}/{repo}/commits/{sha}/comments, organization_administration:read now includes GET /orgs/{org}/actions/cache/usage and GET /orgs/{org}/actions/cache/usage-by-repository, actions:read now includes GET /repos/{owner}/{repo}/actions/cache/usage, actions:administration now includes GET /repos/{owner}/{repo}/traffic/views and GET /repos/{owner}/{repo}/vulnerability-alerts. secret_scanning_alerts permission has been removed #103

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

octokitbot
Copy link
Collaborator

I found new changes on https://docs.github.com/en/rest/reference/permissions-required-for-github-apps/ and thought I'd let you know about it 👋🤖

I can't tell if the changes include fixes, features, breaking changes or just cache updates, you'll have to figure that out on yourself and adapt the commit messages accordingly to trigger the right release, see our commit message conventions.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 2, 2022
@@ -681,19 +692,31 @@
"PUT /repos/{owner}/{repo}/actions/secrets/{secret_name}"
]
},
"secret_scanning_alerts": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timrogers can you verify if this permission was indead removed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't available for the Free, Pro and Teams plans, so it now only appears in the GHEC, GHES and GHEC docs. How do we handle that in this project?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know.

I guess we need app-permissions for the different GH* version as well, or add a key stating in which versions the permission is supported?

For now, I'd suggest to merge and create a follow up issue, so that we are unblocked for further updates

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd agree on that. Makes sense to me.

@gr2m gr2m changed the title 🤖📯 App permissions changed feat: codespaces permission, dependabot_secrets permission, contents:read permission now includes GET /repos/{owner}/{repo}/codeowners/errors",contents:write permission now includes POST /repos/{owner}/{repo}/comments/{comment_id}/reactions and POST /repos/{owner}/{repo}/commits/{sha}/comments, organization_administration:read now includes GET /orgs/{org}/actions/cache/usage and GET /orgs/{org}/actions/cache/usage-by-repository, actions:read now includes GET /repos/{owner}/{repo}/actions/cache/usage, actions:administration now includes GET /repos/{owner}/{repo}/traffic/views and GET /repos/{owner}/{repo}/vulnerability-alerts. secret_scanning_alerts` permission has been removed Jul 4, 2022
@wolfy1339 wolfy1339 changed the title feat: codespaces permission, dependabot_secrets permission, contents:read permission now includes GET /repos/{owner}/{repo}/codeowners/errors",contents:write permission now includes POST /repos/{owner}/{repo}/comments/{comment_id}/reactions and POST /repos/{owner}/{repo}/commits/{sha}/comments, organization_administration:read now includes GET /orgs/{org}/actions/cache/usage and GET /orgs/{org}/actions/cache/usage-by-repository, actions:read now includes GET /repos/{owner}/{repo}/actions/cache/usage, actions:administration now includes GET /repos/{owner}/{repo}/traffic/views and GET /repos/{owner}/{repo}/vulnerability-alerts. secret_scanning_alerts` permission has been removed feat: codespaces permission, dependabot_secrets permission, contents:read permission now includes GET /repos/{owner}/{repo}/codeowners/errors",contents:write permission now includes POST /repos/{owner}/{repo}/comments/{comment_id}/reactions and POST /repos/{owner}/{repo}/commits/{sha}/comments, organization_administration:read now includes GET /orgs/{org}/actions/cache/usage and GET /orgs/{org}/actions/cache/usage-by-repository, actions:read now includes GET /repos/{owner}/{repo}/actions/cache/usage, actions:administration now includes GET /repos/{owner}/{repo}/traffic/views and GET /repos/{owner}/{repo}/vulnerability-alerts. secret_scanning_alerts permission has been removed Jul 4, 2022
@@ -681,19 +692,31 @@
"PUT /repos/{owner}/{repo}/actions/secrets/{secret_name}"
]
},
"secret_scanning_alerts": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't available for the Free, Pro and Teams plans, so it now only appears in the GHEC, GHES and GHEC docs. How do we handle that in this project?

Copy link

@timrogers timrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go ahead and merge this.

@gr2m gr2m merged commit 1678fa9 into main Jul 12, 2022
@gr2m gr2m deleted the update branch July 12, 2022 16:52
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants