-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT]: method for generating installation url #541
Comments
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
what I usually do is to retrieve the app's HTML URL const { data: appInfo } = await app.octokit.request("GET /app")
const installUrl = `${appInfo.html_url}/installations/new` Does that work for you? |
I could definitely use that instead, and the implementation of this method would probably look just like that, I just like the convenience of |
The OAuth URL method is coming from this package: https://github.com/octokit/oauth-methods.js. We don't have a counterpart with methods for apps, but worth thinking about. I suggest we leave this issue open, maybe others can share their perspective and we can pick it up again in future |
Created PR #542 to address this, mostly for fun - let me know what you think! No worries if it doesn't get merged |
🎉 This issue has been resolved in version 15.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Describe the need
We have multiple github apps - one for each environment of our service. We have an endpoint that simply returns the installation url for the github app. Right now, the endpoint looks something like this:
I wish we didn't have to hard-code the github app name or store it as an env var. I noticed that the
@octokit/oauth-app
package has a convenient methodapp.getWebFlowAuthorizationUrl(options)
which generates the authorization URL. I looked for a similar function within the octokit app but wasn't able to find anything. Would be a neat little feature to have - happy to implement as well!SDK Version
No response
API Version
No response
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: