Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): corret types for auth({ type: "installation", installationId, factory }) #301

Merged
merged 1 commit into from
Jun 25, 2021
Merged

fix(typescript): corret types for auth({ type: "installation", installationId, factory }) #301

merged 1 commit into from
Jun 25, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Jun 25, 2021

fixes #204

@gr2m gr2m added Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only labels Jun 25, 2021
@gr2m gr2m merged commit e25c118 into master Jun 25, 2021
@gr2m gr2m deleted the 204/types-for-installation-auth-with-factory branch June 25, 2021 06:49
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return type of auth({ type: "installation", installationId, factory }) should be Promise<ReturnType<factory>>
1 participant
@gr2m