Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename id option to appId #44

Closed
gr2m opened this issue Feb 11, 2020 · 1 comment · Fixed by #207
Closed

rename id option to appId #44

gr2m opened this issue Feb 11, 2020 · 1 comment · Fixed by #207
Assignees
Labels
Type: Feature New feature or request

Comments

@gr2m
Copy link
Contributor

gr2m commented Feb 11, 2020

It will be easier to understand when using with an Octokit instance

const MyOctokit = Octokit.defaults({ authStrategy: createAppAuth })
const octokit = new MyOctokit({
  auth: {
    appId: 123,
    privateKey: PRIVATE_KEY
  }
})

is more clear than

const octokit = new MyOctokit({
  auth: {
    id: 123,
    privateKey: PRIVATE_KEY
  }
})
``
@gr2m gr2m added the Type: Feature New feature or request label Feb 11, 2020
@gr2m gr2m self-assigned this Oct 27, 2020
@gr2m gr2m closed this as completed in #207 Oct 27, 2020
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant