Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Some properties are nullable when they probably shouldn't be #25

Open
1 task done
alexrp opened this issue Jan 4, 2024 · 3 comments
Open
1 task done
Labels
Type: Bug Something isn't working as documented Type: Design Considerations Anything from maintainers/contributors that will help shape this SDK

Comments

@alexrp
Copy link

alexrp commented Jan 4, 2024

What happened?

Take for example the GitHub.Models.Release.Assets property. AFAICT from the API, this property can be an empty array, but never null.

Versions

v0.0.3

Code of Conduct

  • I agree to follow this project's Code of Conduct
@alexrp alexrp added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@alexrp
Copy link
Author

alexrp commented Jan 4, 2024

Another example would seem to be GitHub.Models.ReleaseAsset.Id which, due to being a value type, has to be used as (int)asset.Id!.

@nickfloyd
Copy link
Contributor

Hey @alexrp,

Thank you for getting involved and helping out here!❤ I'm going to chase this down this week and I'll let you know what I find.

@nickfloyd nickfloyd removed the Status: Triage This is being looked at and prioritized label Jan 8, 2024
@nickfloyd nickfloyd added the Type: Design Considerations Anything from maintainers/contributors that will help shape this SDK label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented Type: Design Considerations Anything from maintainers/contributors that will help shape this SDK
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants