Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Some required API parameters could be made clearer in the SDK #26

Open
1 task done
alexrp opened this issue Jan 4, 2024 · 2 comments
Open
1 task done
Labels
Type: Design Considerations Anything from maintainers/contributors that will help shape this SDK Type: Feature New feature or request

Comments

@alexrp
Copy link

alexrp commented Jan 4, 2024

Describe the need

I'm assuming this might require changes in Kiota, so I don't know if this is even the correct place to file this feature request. The API specifies that tag_name is a required parameter for creating a release. Yet, this is not apparent from the ReleasesRequestBuilder.PostAsync(ReleasesPostRequestBody, [...]) method since ReleasesPostRequestBody.TagName is marked as nullable when it should probably be non-nullable and maybe even required. Alternatively, it could be promoted to a required parameter of the PostAsync() method.

SDK Version

v0.0.3

API Version

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@alexrp alexrp added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd removed the Status: Triage This is being looked at and prioritized label Jan 8, 2024
@nickfloyd
Copy link
Contributor

Hey @alexrp Thanks for reaching out on this and providing some solid feedback. We're going to go through this and others and begin refining things. So please keep the thoughts, suggestions and contributions coming!

@nickfloyd nickfloyd added the Type: Design Considerations Anything from maintainers/contributors that will help shape this SDK label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Design Considerations Anything from maintainers/contributors that will help shape this SDK Type: Feature New feature or request
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants