Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update @octokit dependencies to their latest version #2248

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Jul 8, 2022

relates to #2246

@oscard0m oscard0m added dependencies Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Jul 8, 2022
@wolfy1339 wolfy1339 changed the title fix(deps): update dependency @octokit/core to v4 fix(deps): update @octokit dependencies to their latest version Jul 8, 2022
@wolfy1339 wolfy1339 enabled auto-merge (squash) July 8, 2022 13:19
@wolfy1339
Copy link
Member

wolfy1339 commented Jul 8, 2022

I bumped other octokit packages to their latest version

We are getting TypeScript errors now:

src/app.ts(6,14): error TS2742: The inferred type of 'App' cannot be named without a reference to '@octokit/app/node_modules/@octokit/oauth-app'. This is likely not portable. A type annotation is necessary.

@wolfy1339 wolfy1339 disabled auto-merge July 8, 2022 19:29
@wolfy1339 wolfy1339 merged commit e714956 into main Jul 8, 2022
@wolfy1339 wolfy1339 deleted the upgrade-octokit-core-to-v4 branch July 8, 2022 19:32
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

🎉 This PR is included in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants