Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releases#uploadAsset is not compatible with GitHub Enterprise #320

Closed
kyleolsondesign opened this issue Mar 29, 2016 · 2 comments
Closed

Comments

@kyleolsondesign
Copy link

The config passed when instantiating can set the host and pathPrefix properties, which allows us to use GitHub Enterprise servers for most requests, but the releases#uploadAsset route information hardcodes another github.com reference:
https://github.com/mikedeboer/node-github/blob/1c9571cbe4bdfd924f1231ee95992f32d5b8f62d/api/v3.0.0/routes.json#L3667

This makes this API inaccessible for GitHub Enterprise instances

@kyleolsondesign
Copy link
Author

It looks like there are two differences between the GitHub public API and GitHub Enterprise (in API v3 at least):

  1. In public api, host changes to uploads.github.com. In enterprise, the host remains the same
  2. In enterprise, the pathPrefix changes from: /api/v3 to /api/uploads

@kyleolsondesign
Copy link
Author

👍 Tested today. Works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant