-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): switch to esbuild and tsc instead of pika #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Make sure to explicitly mark every type import and export. |
I don't think it's the best idea to move There was a reasoning of putting it in regular If it's not in regular dependencies, then people using this package may not have types in their IDE |
Explicit imports/exports and the previously discussed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Octokit is only being used as a type here
I think I see the problem, the problem is the lockfile here. It's using version 3 which isn't backwards compatible with older versions of npm Can you regenerate it with Node v14? |
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Thanks for the tip! Done. |
@wolfy1339 I've updated this PR with the latest version of octokit/tsconfig. Please take another look when you get a moment! |
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
🎉 This PR is included in version 7.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Replicating octokit/request.js#584 to another repo.
Pika has been deprecated for a while now, and the project has now been archived, and because of that the released npm package is missing most of the files generated by the build step.
Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle
Uses the TypeScript compiler to generate the types.
Behavior
Before the change?
dist-node
,dist-types
,dist-web
... even though they are generated correctly.After the change?
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Maintenance