Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engines): Revert engine back to 16 #432

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

benmvp
Copy link
Contributor

@benmvp benmvp commented Jun 2, 2023

#430 upgraded the Node version to 18, but as a fix released in 4.1.4 (instead of as a breaking change). So it breaks consumers of the library (such as semantic-release) that are still on Node 16.

Resolves #431


Behavior

Before the change?

  • Able to install a package using @ocktokit/plugin-retry with Node 16.

After the change?

  • Unable to install a package using @ocktokit/plugin-retry with Node 16 because it requires Node 18.

Other information

n/a


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

It doesn't. The previous PR did

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

octokit#430 upgraded the Node version to 18, but as a fix (instead of a breaking change). So it breaks consumers of the library (such as [`semantic-release`](https://github.com/semantic-release/semantic-release)) that are still on Node 16.

Fixes octokit#431
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jun 2, 2023
@wolfy1339
Copy link
Member

Can you also update the build script: scripts/build.mjs to use node 16

@benmvp
Copy link
Contributor Author

benmvp commented Jun 2, 2023

Can you also update the build script: scripts/build.mjs to use node 16

done and done!

@wolfy1339 wolfy1339 merged commit 630edf1 into octokit:main Jun 2, 2023
@benmvp benmvp deleted the revert-node-16 branch June 2, 2023 15:04
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This PR is included in version 4.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benmvp
Copy link
Contributor Author

benmvp commented Jun 2, 2023

Thanks for being so responsive @wolfy1339! 🎉 Such a quick turnaround 🙏🏾

@benmvp
Copy link
Contributor Author

benmvp commented Jun 2, 2023

Verified that 4.1.5 fixes things!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: last commit was detected as a fix instead of breaking change (node version)
2 participants