Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(refactor): async await instead of Promise chain #711

Merged
merged 11 commits into from
Jul 13, 2024
Merged

fix(refactor): async await instead of Promise chain #711

merged 11 commits into from
Jul 13, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jul 11, 2024 •
edited
Loading

Use async await for better readability.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 11, 2024
@wolfy1339 wolfy1339 changed the title Break up promise chain fix(refactor): break-up Promise chain Jul 11, 2024
@Uzlopak Uzlopak force-pushed the break-up-promise-chain branch from 2fda9dd to 3714acc Compare July 12, 2024 02:07
@Uzlopak Uzlopak marked this pull request as ready for review July 12, 2024 07:50
@Uzlopak Uzlopak mentioned this pull request Jul 12, 2024
Open
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jul 12, 2024

Yes, it is kind of a heavy change, but it does not contain any breaking change :)

@Uzlopak Uzlopak changed the title fix(refactor): break-up Promise chain fix(refactor): async await instead of Promise chain Jul 12, 2024
wolfy1339
wolfy1339 reviewed Jul 12, 2024
View reviewed changes
src/fetch-wrapper.ts Outdated Show resolved Hide resolved
src/fetch-wrapper.ts Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jul 12, 2024

@wolfy1339
I adapted your requested changes but added the async for getResponseData. I will touch that function in a separate PR.

@Uzlopak Uzlopak mentioned this pull request Jul 12, 2024
Merged
@wolfy1339 wolfy1339 merged commit 611b275 into octokit:main Jul 13, 2024
7 checks passed
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 9.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Aug 3, 2024
Open
Open
This was referenced Sep 9, 2024
Open
Open
@ekmixon ekmixon mentioned this pull request Sep 13, 2024
Open
@rnmeow rnmeow mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy1339 wolfy1339 wolfy1339 approved these changes

Assignees
No one assigned
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @wolfy1339