Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): receive() type improvement for consistency with event-handler one #428

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Feb 2, 2021

📝 Summary

receive() type improvement for consistency with event-handler one:

receive(event: EmitterWebhookEvent): Promise<void>;

⛱ Motivation and Context

Fix #423

@oscard0m oscard0m added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only labels Feb 2, 2021
@oscard0m oscard0m requested review from G-Rath and wolfy1339 February 2, 2021 21:34
@oscard0m oscard0m merged commit 09c83b4 into master Feb 2, 2021
@oscard0m oscard0m deleted the improve-receive-signature branch February 2, 2021 21:57
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

🎉 This PR is included in version 7.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

receive() signature in src/index.ts should be the same one as the one in event-handler/index.ts
2 participants