fix(typescript): resolve correct value for BaseWebhookEvent#name
#435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
added
the
Type: Bug
oscard0m
previously approved these changes
Feb 3, 2021
wolfy1339
previously approved these changes
Feb 3, 2021
wolfy1339
approved these changes
Feb 3, 2021
gr2m
approved these changes
Feb 4, 2021
oscard0m
approved these changes
Feb 4, 2021
Yeah they're actually really nice - I think they're the way to go for testing typescript in other repos. Since everyones approved, I'm guessing we're happy requiring >= 4.1 for Typescript - I'll merge this in an hour or so in case anyone wants to change their mind, but otherwise will 🚀 on |
yes. And if anyone complaints, send them my way 😜 |
|
🎉 This PR is included in version 7.24.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually a lot easier than I expected, but it makes total sense in hindsight.
This does put our minimal TypeScript version at 4.1 or higher - personally I don't have a problem with this, especially since we consider TypeScript changes to be non-breaking, but worth mentioning.
Fixes #431