Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): add enum to delete#ref_type to match create event (via [@octokit/webhooks-definitions v3.58.1](https://github.com/octokit/webhooks/releases/tag/v3.58.1)) #449

Merged
merged 3 commits into from
Feb 7, 2021

Conversation

octokitbot
Copy link
Collaborator

A new release of @octokit/webhooks was just released 👋🤖

This pull request updates the TypeScript definitions derived from @octokit/webhooks. I can't tell if the changes are fixes, features or breaking, you'll have to figure that out on yourself and adapt the commit messages accordingly to trigger the right release, see our commit message conventions.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 7, 2021
@wolfy1339 wolfy1339 changed the title 🚧 🤖📯 Webhooks changed feat: update types from @octokit/webhooks-definitions Feb 7, 2021
wolfy1339
wolfy1339 previously approved these changes Feb 7, 2021
@wolfy1339
Copy link
Member

@gr2m I had to re-run the workflow, when it ran initially it didn't pick up the latest version.

@wolfy1339
Copy link
Member

And the same thing happened again... What is going on with npm? It doesn't pick up the latest release version

@G-Rath
Copy link
Member

G-Rath commented Feb 7, 2021

@wolfy1339 npm is backed by a sizable cache setup, so it can sometimes take upwards of 10 minutes before a new package propagates to the whole of the registry

@wolfy1339
Copy link
Member

That's understandable, however why has the issue never come up before until now

@G-Rath
Copy link
Member

G-Rath commented Feb 7, 2021

I've definitely had this issue a few times over at my repo - it seems to me like it happens typically when you do a couple of releases very quickly.


However, looking at the logs & PR, it seems to me that it has picked up the latest version? What version would you expect it to be bumping us to in this PR?

@wolfy1339
Copy link
Member

Everything is fine now. But I had to manually re-request the action be run.

@G-Rath
Copy link
Member

G-Rath commented Feb 7, 2021

Oh, I didn't think you had because it said "Update #100: Repository dispatch triggered by octokit-release-notifier bot" but all good.

In that case, that'd point to the app being the problem rather than npm, since its the one that should be triggering the actions.
I suspect it might be some sort of debounce somewhere that occurs when you have a few releases happen very quickly.

@wolfy1339
Copy link
Member

Can we check if the release is a pre-release and then install using the release's version number instead of relying on npm to update @latest (and the caching involved)?

@G-Rath
Copy link
Member

G-Rath commented Feb 7, 2021

That caching is inherent in the whole system, it's not just the @latest tag.

But the fact that the action didn't fire at all means that we should be looking at the app rather than the action :)

@gr2m
Copy link
Contributor

gr2m commented Feb 7, 2021

I've built https://github.com/gr2m/await-npm-package-version-action/ to address the delay between an npm publish and the availablity of the new version in the registry, e.g. see

https://github.com/octokit/openapi-types.ts/blob/ef4ea6bdb24d85cb094bba8751829bbecc835ffd/.github/workflows/update.yml#L34-L37

Let's add that to this repository's update workflow

@gr2m
Copy link
Contributor

gr2m commented Feb 7, 2021

when merging, ideally we would make the squash commit more useful than

feat: update types from @octokit/webhooks-definitions

depending on what changes are relevant to @octokit/webhooks users. In this case something like this maybe?

fix(typescript): add enum to delete#ref_type to match create event (via @octokit/webhooks-definitions v3.58.1)

@wolfy1339 wolfy1339 changed the title feat: update types from @octokit/webhooks-definitions fix(typescript): add enum to delete#ref_type to match create event (via [@octokit/webhooks-definitions v3.58.1](https://github.com/octokit/webhooks/releases/tag/v3.58.1)) Feb 7, 2021
@wolfy1339 wolfy1339 merged commit fd1477c into master Feb 7, 2021
@wolfy1339 wolfy1339 deleted the update-octokit-webhooks branch February 7, 2021 21:27
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2021

🎉 This PR is included in version 7.24.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021

🎉 This PR is included in version 8.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants