-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript): add enum to delete#ref_type
to match create
event (via [@octokit/webhooks-definitions
v3.58.1](https://github.com/octokit/webhooks/releases/tag/v3.58.1))
#449
Conversation
@octokit/webhooks-definitions
@gr2m I had to re-run the workflow, when it ran initially it didn't pick up the latest version. |
And the same thing happened again... What is going on with npm? It doesn't pick up the latest release version |
@wolfy1339 npm is backed by a sizable cache setup, so it can sometimes take upwards of 10 minutes before a new package propagates to the whole of the registry |
That's understandable, however why has the issue never come up before until now |
I've definitely had this issue a few times over at my repo - it seems to me like it happens typically when you do a couple of releases very quickly. However, looking at the logs & PR, it seems to me that it has picked up the latest version? What version would you expect it to be bumping us to in this PR? |
Everything is fine now. But I had to manually re-request the action be run. |
Oh, I didn't think you had because it said "Update #100: Repository dispatch triggered by octokit-release-notifier bot" but all good. In that case, that'd point to the app being the problem rather than |
Can we check if the release is a pre-release and then install using the release's version number instead of relying on npm to update |
That caching is inherent in the whole system, it's not just the But the fact that the action didn't fire at all means that we should be looking at the app rather than the action :) |
I've built https://github.com/gr2m/await-npm-package-version-action/ to address the delay between an npm publish and the availablity of the new version in the registry, e.g. see Let's add that to this repository's update workflow |
when merging, ideally we would make the squash commit more useful than
depending on what changes are relevant to
|
@octokit/webhooks-definitions
delete#ref_type
to match create
event (via [@octokit/webhooks-definitions
v3.58.1](https://github.com/octokit/webhooks/releases/tag/v3.58.1))
🎉 This PR is included in version 7.24.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 8.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
A new release of @octokit/webhooks was just released 👋🤖
This pull request updates the TypeScript definitions derived from
@octokit/webhooks
. I can't tell if the changes are fixes, features or breaking, you'll have to figure that out on yourself and adapt the commit messages accordingly to trigger the right release, see our commit message conventions.