Project: Extract events logic from @octokit/webhooks
into @octokit/events
#474
Labels
project
Goes beyond a single bug fix or new feature. Help welcome by existing contributors.
Not all GitHub Events are sent via webhooks. Some are only available to GitHub Actions, such as the
schedule
event.I would like to move all event-related logic into a new
@octokit/events
package. It will essentially beEventHandler
class from /src/event-handler@octokit/webhooks
should only care about webhooks-specific logicWith that change, we should rename the
@octokit/webhooks-definitions
to@octokit/events-defintions
, too. The definitions should include a flag whether an event is also sent as a Webhook request by GitHub.This is also a good opportunity to clean up the code base.
@octokit/webhooks
is one of the olders @octokit modules, a lot has change since, most importantly the rewrite to TypeScript. When creating@octokit/events
, we can start with a blank page and do not need to worry about breaking any APIs. Once the module is done, we will be able to remove a big chunk of the code in@octokit/webhooks
and instead replace it with the@octokit/events
dependency. We can release a breaking change for@octokit/webhooks
if necessary at this point.This will be a larger effort that I need to be involved in, but it's not time critical. If anyone would like to take a lead on the effort, let's discuss in the comments
The text was updated successfully, but these errors were encountered: